Skip to content

fix numbering in export-as-tiff CLI #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

fix numbering in export-as-tiff CLI #1387

merged 4 commits into from
Oct 30, 2025

Conversation

@normanrz
Copy link
Member

@normanrz normanrz commented Oct 28, 2025 •
edited by fm3
Loading

Description:

  • in export_as_tiff cli tool, output filename numbering now reflects reflect z index in wk, so in mag4, it give 0,4,8…

Todo

  • Updated Changelog

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10120 8498 84% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
webknossos/webknossos/cli/export_as_tiff.py 54% 🟢
TOTAL 54% 🟢

updated for commit: 5c27df7 by action🐍

@fm3 fm3 marked this pull request as ready for review October 30, 2025 12:38
fm3
fm3 approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) I added a commit renaming some variables to hopefully make this easier to understand in the future

@normanrz normanrz enabled auto-merge (squash) October 30, 2025 12:50
@normanrz normanrz merged commit a760a09 into master Oct 30, 2025
23 checks passed
@normanrz normanrz deleted the export-tiff-numbers branch October 30, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@fm3 fm3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@normanrz @fm3